Ignore faulty GPUs when listing GPUs - #66
Open
geobeau wants to merge 1 commit into
Open
Conversation
On servers with some of the GPUs broken, we want to continue using the other GPUs. However, when computing the topology, it fails on GPU Lost state. Signed-off-by: g.beausire <[email protected]>
Author
|
cc @rajatchopra, sorry for the ping but you are the last one that merged something on the repo, do you mind taking a look? |
kvalliyurnatt
previously requested changes
Sep 2, 2026
kvalliyurnatt
dismissed
their stale review
September 2, 2026 18:35
I reread the goal of the PR, operator already knows about the broken GPUs. OS my comments are not valid in this case
| for i := 0; i < nvml.NVLINK_MAX_LINKS; i++ { | ||
| state, ret := dev.GetNvLinkState(i) | ||
| if ret == nvml.ERROR_NOT_SUPPORTED || ret == nvml.ERROR_INVALID_ARGUMENT { | ||
| if ret == nvml.ERROR_NOT_SUPPORTED || ret == nvml.ERROR_INVALID_ARGUMENT || ret == nvml.ERROR_GPU_IS_LOST { |
There was a problem hiding this comment.
Could we add a higher-level test demonstrating the expected operator flow: topology discovery tolerates ERROR_GPU_IS_LOST, the known-broken GPU is excluded from the allocation set, and BestEffort successfully evaluates the remaining healthy GPUs? This would document the caller-side filtering assumption and why incomplete links involving the broken GPU are safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the case where a server has some of the GPUs in a broken state, however we want to continue using the other GPUs. While the nvidia operator is aware that these GPUs are out, it fails when computing GPU topology.
The goal of this PR is to skip broken GPUs when computing the topology